Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the file path for the Button story #9325

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Correct the file path for the Button story #9325

merged 4 commits into from
Feb 4, 2020

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Jan 4, 2020

Issue: I happened to notice that the file path for the Button story was incorrect when looking at Storybook for React tutorial.

What I did

Corrected the file path for the Button story.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jan 4, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/rjzottv5g
✅ Preview: https://monorepo-git-fork-daleseo-patch-3.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaleSeo, good catch! However, the Button stories are actually located at 1-Button.stories.js! Mind updating?

Also, this seems to be a problem across the Welcome component in ALL frameworks. Any chance you might be able to update the others? I'd really appreciate it!

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaleSeo, good catch! However, the Button stories are actually located at 1-Button.stories.js! Mind updating?

Also, this seems to be a problem across the Welcome component in ALL frameworks. Any chance you might be able to update the others? I'd really appreciate it!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 5, 2020
@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 5, 2020

Oops! Sorry @shamin, you're right. I've updated it!

In terms of updating the others, since I'm not very familiar with this project, I just manually searched for some places and tried to update as much as I could.

I also look for the vue example and found it has the correct path.

located at <code class="code">src/stories/Button.js</code>.)

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 5, 2020

I think my changes break some snapshot testing. I guess I need to learn just -u to update the snapshots?

@DaleSeo DaleSeo requested a review from shilman January 5, 2020 22:37
@shilman
Copy link
Member

shilman commented Jan 6, 2020

Thanks! Yeah, you should be able to do yarn test --core --update

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 7, 2020

@shilman I've updated the snapshots but I think chromatic tests are failing now. Could you advise?

@shilman
Copy link
Member

shilman commented Jan 7, 2020

Thanks @DaleSeo!! I'll take care of Chromatic & merge. Much appreciated 🙏🙏🙏

@shilman shilman removed documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 7, 2020
@shilman shilman modified the milestone: 5.3.0 Jan 7, 2020
@shilman shilman added this to the 5.3.x milestone Jan 11, 2020
@stale
Copy link

stale bot commented Feb 1, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants