Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from simplebar to overlaybars #9375

Merged
merged 24 commits into from
Mar 10, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 9, 2020

Issue:
When updating simplebars to latest it breaks, it has no typescript typings

What I did

  • migrate to overflowbars from simplebars for custom scrollbars
  • change snapshots to output html
  • add jest-serializer-html to make html snapshots more reviewable

@ndelangen ndelangen added this to the 6.0.0 milestone Jan 9, 2020
@ndelangen ndelangen requested a review from tmeasday as a code owner January 9, 2020 22:04
@ndelangen ndelangen self-assigned this Jan 9, 2020
@vercel
Copy link

vercel bot commented Jan 9, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/rath3zcim
✅ Preview: https://monorepo-git-migrate-from-simplebar-to-overlaybars-2.storybook.now.sh

@vercel vercel bot temporarily deployed to Preview January 9, 2020 23:25 Inactive
@vercel vercel bot temporarily deployed to Preview January 10, 2020 23:36 Inactive
@ndelangen ndelangen changed the base branch from next-6.0.0 to next January 20, 2020 10:29
# Conflicts:
#	addons/a11y/src/components/A11YPanel.test.js
#	addons/a11y/src/components/__snapshots__/A11YPanel.test.js.snap
#	lib/components/package.json
@vercel vercel bot temporarily deployed to Preview January 20, 2020 10:34 Inactive
# Conflicts:
#	lib/components/package.json
#	yarn.lock
# Conflicts:
#	lib/components/package.json
# Conflicts:
#	addons/info/src/__snapshots__/index.test.js.snap
#	addons/info/src/index.test.js
#	lib/components/package.json
#	yarn.lock
# Conflicts:
#	lib/components/package.json
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @domyen?

@stale
Copy link

stale bot commented Feb 29, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 29, 2020
@domyen
Copy link
Member

domyen commented Feb 29, 2020

Awesome update @ndelangen! I noticed the sidebar scrollbar is no longer draggable. It seems like the "draggable" area for resizing the canvas/addons panel is preventing me from dragging the scrollbar down.

Overlaybars (notice that I can't click and drag)
https://www.loom.com/share/989514c894f34ccf8307d0245c5b8258

Simplebars (notice that I can click and drag)
https://www.loom.com/share/b3472df0625f4d14aa647285c2b59a7b

@stale stale bot removed the inactive label Feb 29, 2020
@ndelangen
Copy link
Member Author

Thank you for the review @domyen I'll tackle this comment asap.

@ndelangen ndelangen requested a review from igor-dv as a code owner March 10, 2020 18:38
@ndelangen ndelangen merged commit 9a46db5 into next Mar 10, 2020
@ndelangen ndelangen deleted the migrate-from-simplebar-to-overlaybars-2 branch March 10, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants