-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from simplebar to overlaybars #9375
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/rath3zcim |
# Conflicts: # addons/a11y/src/components/A11YPanel.test.js # addons/a11y/src/components/__snapshots__/A11YPanel.test.js.snap # lib/components/package.json
# Conflicts: # lib/components/package.json # yarn.lock
# Conflicts: # lib/components/package.json
# Conflicts: # addons/info/src/__snapshots__/index.test.js.snap # addons/info/src/index.test.js # lib/components/package.json # yarn.lock
# Conflicts: # lib/components/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @domyen?
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Awesome update @ndelangen! I noticed the sidebar scrollbar is no longer draggable. It seems like the "draggable" area for resizing the canvas/addons panel is preventing me from dragging the scrollbar down. Overlaybars (notice that I can't click and drag) Simplebars (notice that I can click and drag) |
Thank you for the review @domyen I'll tackle this comment asap. |
# Conflicts: # lib/components/package.json # package.json # yarn.lock
Issue:
When updating simplebars to latest it breaks, it has no typescript typings
What I did