Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix link CORS errors using channel navigate event #9381

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Addon-docs: Fix link CORS errors using channel navigate event #9381

merged 1 commit into from
Jan 11, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 10, 2020

Issue: #9328

What I did

How to test

See include test cases in official-storybook

@shilman shilman requested a review from usulpro as a code owner January 10, 2020 14:51
@vercel
Copy link

vercel bot commented Jan 10, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/3hf1l2hb1
✅ Preview: https://monorepo-git-9328-fix-docs-cors-errors.storybook.now.sh

This was referenced Jan 10, 2020
Closed
Closed
atanasster
atanasster approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@atanasster atanasster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@shilman shilman requested a review from tmeasday January 11, 2020 00:06
@shilman shilman merged commit c5d9783 into next Jan 11, 2020
@shilman shilman deleted the 9328-fix-docs-cors-errors branch January 11, 2020 02:09
@shilman shilman added this to the 5.3.0 milestone Jan 11, 2020
@shilman shilman mentioned this pull request Jan 11, 2020
Closed
This was referenced Jan 20, 2020
Closed
Closed
Closed
@lili2311 lili2311 mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanasster atanasster atanasster approved these changes

@ndelangen ndelangen ndelangen approved these changes

@usulpro usulpro Awaiting requested review from usulpro

@patricklafrance patricklafrance Awaiting requested review from patricklafrance

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: docs bug
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @ndelangen @atanasster