Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoprefixer as peer dependency. #9409

Closed
wants to merge 1 commit into from

Conversation

ruimarques
Copy link

Issue:

autoprefixer is already a dependency from @storybook/core which is a dependency from this @storybook/angular package.

The versions mismatch, causing a:

npm WARN @storybook/angular@5.3.1 requires a peer of autoprefixer@^8.1.0 but none is installed. You must install peer dependencies yourself.

$ npm ls autoprefixer
Screenshot 2020-01-13 at 13 20 24

What I did

Removed autoprefixer as peer dependency.
Alternative would be to keep autoprefixer version matching with the one from @storybook/core ...

@vercel
Copy link

vercel bot commented Jan 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jlcrm2viq
✅ Preview: https://monorepo-git-fork-ruimarques-patch-4.storybook.now.sh

@stale
Copy link

stale bot commented Feb 3, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 3, 2020
@stale
Copy link

stale bot commented Mar 4, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants