-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-loader: Disable linting altogether #9417
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/4qkkg7mqk |
Self-merging @tmeasday @ndelangen @mrmckeb |
I'm thinking this may be causing an issue when eslint is integrated into the webpack config and part of the reloading:
The initial build works fine, but saves after error out. This worked fine in 5.3.1, but everything after has this issue. |
@zslabs what do you think is going on? And what is your setup? CRA? Do you have a repro available? |
1 similar comment
@zslabs what do you think is going on? And what is your setup? CRA? Do you have a repro available? |
Sorry, that was a very vague implementation I had on my end. You can find the complete repo at https://github.com/gremlin/chaoskit/tree/feature/emotion If you download, and run |
Anymore info I could provide here? Should I open up an issue? |
Issue: #9407 #9423
What I did
More aggressive than #9410 - just disable linting entirely in these synthetic files. Since this happens at load time, it shouldn't affect users' linting in general.
How to test
Didn't test