Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Preserve kind load order on HMR when no sortFn is provided #9424

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Core: Preserve kind load order on HMR when no sortFn is provided #9424

merged 3 commits into from
Jan 14, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 14, 2020 •
edited
Loading

Issue: #9419

What I did

Preserve kind order when stories are edited.

How to test

See attached test case. Also edit stories that are not last in the list in a project where no sort order is specified.

@vercel
Copy link

vercel bot commented Jan 14, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/5m5yqvfu5
✅ Preview: https://monorepo-git-9419-fix-hmr-order.storybook.now.sh

@shilman shilman changed the title Core: Test order preservation in clientApi HMR Core: Preserve kind load order on HMR when no sortFn is provided Jan 14, 2020
@shilman shilman added bug core patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 14, 2020
@shilman shilman requested a review from tmeasday January 14, 2020 06:25
@shilman shilman added this to the 5.3.x milestone Jan 14, 2020
tmeasday
tmeasday approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comment could maybe be improved.

lib/client-api/src/story_store.ts Outdated Show resolved Hide resolved
@shilman shilman merged commit 0e3ff1d into next Jan 14, 2020
@shilman shilman deleted the 9419-fix-hmr-order branch January 14, 2020 08:32
@shilman shilman mentioned this pull request Jan 14, 2020
Closed
@benmvp benmvp mentioned this pull request Jan 15, 2020
Closed
@benmvp
Copy link

benmvp commented Jan 15, 2020

@shilman I think this may have caused the bug I've mentioned in #9477. I left some details there...

@shilman shilman mentioned this pull request Jan 16, 2020
Merged
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
@shilman shilman mentioned this pull request Jan 24, 2020
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @benmvp @tmeasday