Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #9440 from ludo237/patch-3 #9440

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Merge pull request #9440 from ludo237/patch-3 #9440

merged 1 commit into from
Jan 14, 2020

Conversation

ludo237
Copy link
Contributor

@ludo237 ludo237 commented Jan 14, 2020

Issue:

What I did

I fixed a bug on a snippet inside the documentation

How to test

  • Is this testable with Jest or Chromatic screenshots? I guess yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jan 14, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/8egspco3h
✅ Preview: https://monorepo-git-fork-ludo237-patch-3.storybook.now.sh

@ndelangen ndelangen changed the base branch from master to next January 14, 2020 12:11
@ndelangen ndelangen added this to the 5.3.x milestone Jan 14, 2020
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 14, 2020
@shilman shilman changed the title Add missing = on module export Merge pull request #9440 from ludo237/patch-3 Jan 14, 2020
@shilman shilman merged commit a07bf12 into storybookjs:next Jan 14, 2020
@ludo237 ludo237 deleted the patch-3 branch January 14, 2020 13:26
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
@Hypnosphi Hypnosphi mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ludo237 @ndelangen @shilman