Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BBC to list of examples #9510

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Add BBC to list of examples #9510

merged 1 commit into from
Jan 18, 2020

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Jan 17, 2020 •
edited
Loading

Issue:

What I did

Added the BBC's psammead react component library to the list of examples.

How to test

  • Does this need an update to the documentation? Yes

@vercel
Copy link

vercel bot commented Jan 17, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/1jycns553
✅ Preview: https://monorepo-git-fork-harveypeachey-next.storybook.now.sh

@ndelangen ndelangen added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 18, 2020
@ndelangen ndelangen merged commit 1a9b2db into storybookjs:next Jan 18, 2020
@shilman
Copy link
Member

shilman commented Jan 18, 2020

@ndelangen @HarveyPeachey there's no bbc.jpg in the PR

@ndelangen
Copy link
Member

@HarveyPeachey could you please add it asap?

Should I revert @shilman ?

@shilman
Copy link
Member

shilman commented Jan 18, 2020

Yeah let's revert until there's a thumbnail 🙏

@ndelangen ndelangen mentioned this pull request Jan 18, 2020
Merged
@HarveyPeachey
Copy link
Contributor Author

@shilman @ndelangen There is a bbc.jpg? https://github.com/HarveyPeachey/storybook/blob/246734b7bc0e48502d1218d36d11e599509e0efc/docs/src/pages/examples/thumbnails/bbc.jpg

Or have I put it in the wrong directory?

@shilman
Copy link
Member

shilman commented Jan 21, 2020

sorry @HarveyPeachey my bad -- completely missed that somehow 🙈

will get this fixed. thanks for your patience.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 21, 2020
shilman pushed a commit that referenced this pull request Jan 21, 2020
@ndelangen @shilman
Add BBC to list of examples (#9510)
016bc71 
Add BBC to list of examples
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarveyPeachey @shilman @ndelangen