Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-logger: Move @types/npmlog to dependencies #9538

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Node-logger: Move @types/npmlog to dependencies #9538

merged 1 commit into from
Jan 20, 2020

Conversation

gaetanmaisse
Copy link
Member

Issue: #7855

What I did

As npmlog is exported here --export { npmLog as instance };, TS users of this lib need to have npmlog types too, so @types/npmlog have to be in dependencies and not in devDependencies.

@gaetanmaisse
fix: move @types/npmlog to dependencies as node-logger is exporti…
f96900c 
…ng `npmlog`

As `npmlog` is exported (`export { npmLog as instance };`), TS users of this lib need to have `npmlog` types too, so `@types/npmlog` have to be in `dependencies` and not `devDependencies`
@gaetanmaisse gaetanmaisse added bug patch:yes Bugfix & documentation PR that need to be picked to main branch typescript labels Jan 19, 2020
@vercel
Copy link

vercel bot commented Jan 19, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/6ge6pa53l
✅ Preview: https://monorepo-git-fix-node-logger-missing-dep.storybook.now.sh

@gaetanmaisse gaetanmaisse mentioned this pull request Jan 19, 2020
Closed
@shilman shilman added this to the 5.3.x milestone Jan 20, 2020
shilman
shilman approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title fix: move @types/npmlog to dependencies Node-logger: Move @types/npmlog to dependencies Jan 20, 2020
@shilman shilman merged commit 5292bd6 into next Jan 20, 2020
@shilman shilman deleted the fix-node-logger-missing-dep branch January 20, 2020 06:39
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 21, 2020
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@dangreenisrael dangreenisrael Awaiting requested review from dangreenisrael

Assignees
No one assigned
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @shilman