Patch for Issue 9294 #9698
Closed
Patch for Issue 9294 #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch was suggested here: https://github.com/storybookjs/storybook/issues/9294#issuecomment-580582681 Credit: @arlyon
ndelangen
reviewed
Feb 3, 2020
| @@ -176,7 +176,7 @@ export const applyHooks = ( | |||
| const { hooks } = context; | |||
| hooks.prevMountedDecorators = hooks.mountedDecorators; | |||
| hooks.mountedDecorators = new Set([getStory, ...decorators]); | |||
| hooks.currentContext = context; | |||
| hooks.currentContext = Object.assign({}, context, { hooks: null }); | |||
There was a problem hiding this comment.
This would ensure the ref to hooks.currentContext is always new/different.
And it would always overload context.hooks with null
That doesn't seem right to me.
What about:
Suggested change
| hooks.currentContext = Object.assign({}, context, { hooks: null }); | |
| hooks.currentContext = context || { hooks: null }; |
?
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch was suggested here: https://github.com/storybookjs/storybook/issues/9294#issuecomment-580582681
Credit: @arlyon
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.