-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Snapshot testing and bug reporting for props tables #9838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this seems good.
fixtures.forEach(fixture => { | ||
// eslint-disable-next-line import/no-dynamic-require, global-require | ||
const { component } = require(`./__testfixtures__/${fixture}/input`); | ||
const props = extractProps(component); | ||
stories.add(fixture, () => <PropsTable {...props} />); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also just manually do the exports so this file can be CSF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without knowing much about snapshot testing => LGTM
selector: 'doc-button', | ||
}) | ||
export class InputComponent<T> { | ||
@ViewChild('buttonRef', { static: false }) buttonRef: ElementRef; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViewChild('buttonRef', { static: false }) buttonRef: ElementRef; | |
@ViewChild('buttonRef') buttonRef: ElementRef; |
this defaults to false in Angular 9 (I think the angular 9 update PR should be merged already? 🤔 )
Not super important but makes it easier to read
@shilman So, are typescript prop tables supported natively on the latest beta without edit: I'm asking because I can't find any explicit reference to that in the pr :) |
Yes. Still working out the dependencies tho |
Hi @shilman, I would like to know any news about props table for Vue, I'm currently testing on https://github.com/vue-styleguidist/vue-styleguidist/tree/dev/packages/vue-docgen-api#events https://github.com/vue-styleguidist/vue-styleguidist/tree/dev/packages/vue-docgen-api#slots |
Issue: #9836
What I did
How to test
See attached tests