-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: fix React Scripts csf-ts story templates #9863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the template folder that has been forgotten in 3dd714d
gaetanmaisse
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
February 14, 2020 20:57
shilman
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Feb 15, 2020
shilman
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @gaetanmaisse !!!
shilman
removed
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Feb 25, 2020
This was referenced Dec 16, 2020
This was referenced Feb 22, 2021
This was referenced Mar 7, 2021
This was referenced Apr 21, 2021
This was referenced May 26, 2021
This was referenced Jun 8, 2021
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the template folder that has been forgotten in 3dd714d
I tried to use a Glob pattern instead of listing all the different folder however it is not entirely supported by Babel: babel/babel#9680 😞