fix: prefix coverage environment variable with storybook

storybookjs · Jun 13, 2022 · 01a9e79 · 01a9e79
1 parent 902dd7d
commit 01a9e79
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -262,7 +262,7 @@ jobs:
 
 ## Setting up code coverage
 
-The test runner supports code coverage with the `--coverage` flag or `COLLECT_COVERAGE` environment variable. The pre-requisite is that your components are instrumented using [istanbul](https://istanbul.js.org/).
+The test runner supports code coverage with the `--coverage` flag or `STORYBOOK_COLLECT_COVERAGE` environment variable. The pre-requisite is that your components are instrumented using [istanbul](https://istanbul.js.org/).
 
 ### Instrument the code
 

diff --git a/bin/test-storybook.js b/bin/test-storybook.js
@@ -172,7 +172,7 @@ const main = async () => {
   process.env.TARGET_URL = targetURL;
 
   if (runnerOptions.coverage) {
-    process.env.COLLECT_COVERAGE = 'true';
+    process.env.STORYBOOK_COLLECT_COVERAGE = 'true';
   }
 
   if (process.env.REFERENCE_URL) {
@@ -212,7 +212,7 @@ const main = async () => {
 
   await executeJestPlaywright(jestOptions);
 
-  if (process.env.COLLECT_COVERAGE === 'true') {
+  if (process.env.STORYBOOK_COLLECT_COVERAGE === 'true') {
     printCoverageReport();
   }
 };

diff --git a/playwright/jest-setup.js b/playwright/jest-setup.js
@@ -13,4 +13,4 @@ if (testRunnerConfig) {
   }
 }
 
-global.__sbCollectCoverage = process.env.COLLECT_COVERAGE === 'true'
+global.__sbCollectCoverage = process.env.STORYBOOK_COLLECT_COVERAGE === 'true'
diff --git a/src/config/jest-playwright.ts b/src/config/jest-playwright.ts
@@ -1,6 +1,11 @@
 export const getJestConfig = () => {
-  const { TEST_ROOT, TEST_MATCH, STORYBOOK_STORIES_PATTERN, TEST_BROWSERS, COLLECT_COVERAGE } =
-    process.env;
+  const {
+    TEST_ROOT,
+    TEST_MATCH,
+    STORYBOOK_STORIES_PATTERN,
+    TEST_BROWSERS,
+    STORYBOOK_COLLECT_COVERAGE,
+  } = process.env;
 
   let config = {
     rootDir: process.cwd(),
@@ -21,7 +26,7 @@ export const getJestConfig = () => {
         browsers: TEST_BROWSERS.split(',')
           .map((p) => p.trim().toLowerCase())
           .filter(Boolean),
-        collectCoverage: COLLECT_COVERAGE === 'true',
+        collectCoverage: STORYBOOK_COLLECT_COVERAGE === 'true',
       },
     },
     watchPlugins: [