-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with Jest 28: Got error running globalSetup
#99
Comments
Hey @ifahrentholz thanks for opening this issue. In the meantime, I believe you can try to add package resolutions to lock these libraries to these versions:
I haven't tested that myself but I think it might work. |
Hi @yannbf,
Thanks for your help 🥇 |
Hey everyone, sorry this is still ongoing. We need help from the jest-playwright maintainers in order to solve this. |
Got error running globalSetup
@yannbf, a fix was just released in https://github.com/playwright-community/jest-playwright/releases/tag/v1.7.1. 🙌 |
Thanks! I was in contact with the maintainer. Unfortunately that's not the good long term fix, but it does help a lot already. I'll take a stab at jest 28 support in their lib at some point. They're quite busy now with other projects (e.g. component testing) so they don't have resources right now for this |
FWIW I also added a warning for Jest 28 users at #111 |
I've taken a look at It's awaiting the workflow runs as not contributed to them before, but I ran them on my fork and they all passed. |
* downgrade to Jest@27 due to current incompatibility with @28 (see storybookjs/test-runner#99)
Looks like some good news, finally. jest-playwright released v2.0.0 today. It contains the upgrade to jest@28. |
jest-playwright v.2.0.0 only supports Jest 28+. Would we have to do the same for |
I don't maintain jest-playwright, but that would be my assumption. I don't see how you could support jest < 28 if you rely on jest-playwright. |
I guess we would have to bump a new major version. That's what semver is for, no big deal imho |
Hey peeps, thanks to @andykenw we've got a great PR already, I'll take care of this and release a new version soon this week! |
Any plan to move forward? |
Hey peeps! This was released and is available now in v0.6.0-next.1, would you mind giving it a try and giving some feedback? Thanks! |
Hi @yannbf, |
I was having the same issue and trying to use resolutions os peerDependencies didn't work for me. I'm using the latest create-react-app for my project and react-scripts 5.0.1 installs jest 27. Digging deep into this, we figure it out that My solution: I'm not sure if it's the right thing to do, but it worked for me. |
Thanks @juliaramosguedes ! The newer versions of the test-runner fixed that, can you remove the dependencies and try it out? |
Hey @yannbf I can't speak for @juliaramosguedes but his suggestion of running |
Describe the bug
Starting
npm run test-storybook
fails with an TypeErrorSteps to reproduce the behavior
start storybook
start test-storybook
Expected behavior
test-runner should run the tests defined as play functions inside the story.
Environment
Repository
https://github.com/ifahrentholz/storybook-test-runner-bug
The text was updated successfully, but these errors were encountered: