Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies #187

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Add missing dependencies #187

merged 1 commit into from
Sep 5, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Sep 4, 2022

I'm doing an experiment to remove some unused dependencies from core Storybook packages, and found that some of the Vite sandboxes started to fail when the test-runner was run, due to missing @babel/ dependencies. Then I noticed that test-runner doesn't actually depend on them correctly. It's using babel to perform transforms, so I think it should include them in dependencies not devDependencies.

I also ran npx depcheck and located a few other deps that the test-runner is relying on, but isn't specifying directly, so I added those as well.

Version

Published prerelease version: v0.7.1-next.0

Changelog

🐛 Bug Fix

Authors: 1

@codecov-commenter
Copy link

Codecov Report

Merging #187 (c42963d) into next (380ed6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #187   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files          11       11           
  Lines         179      179           
  Branches       37       37           
=======================================
  Hits          137      137           
  Misses         42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IanVS IanVS requested review from shilman and yannbf September 4, 2022 03:07
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @yannbf

@shilman shilman merged commit d7222ef into next Sep 5, 2022
@shilman shilman deleted the missing-deps branch September 5, 2022 16:54
@yannbf yannbf mentioned this pull request Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🚀 PR was released in v0.7.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants