Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update snapshot command to cli #52

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 15, 2022

In case people are using test hooks for snapshot testing, it's important to expose this jest flag to update the snapshots without having to go into watch mode

📦 Published PR as canary version: 0.0.3-canary.52.ec4fcc0.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.3-canary.52.ec4fcc0.0
# or 
yarn add @storybook/test-runner@0.0.3-canary.52.ec4fcc0.0

Version

Published prerelease version: v0.0.3-next.2

Changelog

🐛 Bug Fix

  • feat: add update snapshot command to cli #52 (@yannbf)
  • fix: improve error message in start-storybook #51 (@yannbf)
  • Respect stories defined in main.js #46 (@yannbf)

Authors: 1

@yannbf yannbf added the patch Increment the patch version when merged label Feb 15, 2022
@yannbf yannbf force-pushed the feat/add-update-snapshot-cli-option branch from e9fb1bc to 7f2568f Compare February 15, 2022 10:50
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Update README?

@yannbf yannbf force-pushed the feat/add-update-snapshot-cli-option branch from 7f2568f to ec4fcc0 Compare February 15, 2022 11:07
@yannbf
Copy link
Member Author

yannbf commented Feb 15, 2022

Great catch. Done!

@yannbf yannbf requested a review from shilman February 15, 2022 11:48
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants