Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document stories not showing up on storybook UI until device connects #1221

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 8, 2017

Issue: N/A

What I did

Document wonky RN storybook behavior for first time users

How to test

N/A

@codecov
Copy link

codecov bot commented Jun 8, 2017

Codecov Report

Merging #1221 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   13.72%   13.72%           
=======================================
  Files         207      207           
  Lines        4640     4640           
  Branches      520      514    -6     
=======================================
  Hits          637      637           
- Misses       3543     3550    +7     
+ Partials      460      453    -7
Impacted Files Coverage Δ
...react-native/src/manager/components/PreviewHelp.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 20% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467d671...eb15170. Read the comment docs.

@orta
Copy link
Member

orta commented Jun 8, 2017

This makes sense 👍

@slorber
Copy link
Contributor

slorber commented Jun 8, 2017

@shilman what would be very great is to have a big green/red icon in the welcome page of http://localhost:7007/, just under the instructions, to tell the user weither or not the storybook has received an incoming connexion from device

@shilman
Copy link
Member Author

shilman commented Jun 8, 2017

@slorber that's a great idea. PR's welcome!!

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 85da42c into master Jun 9, 2017
@shilman shilman deleted the improve-rn-welcome branch June 9, 2017 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants