Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cra-kitchen-sink package versions for 3.2-alpha #1434

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 8, 2017

Issue: #1433

What I did

Update the versions (see issue for more info on why)

How to test

See discussion on #1432

  • make any change to @storybook/ui
  • run npm run bootstrap
  • change should be visible in cra-kitchen-sink

@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jul 8, 2017

Codecov Report

Merging #1434 into release/3.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.2    #1434   +/-   ##
============================================
  Coverage        15.91%   15.91%           
============================================
  Files              237      237           
  Lines             5047     5047           
  Branches           698      696    -2     
============================================
  Hits               803      803           
+ Misses            3671     3666    -5     
- Partials           573      578    +5
Impacted Files Coverage Δ
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 11.11% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
addons/notes/src/react.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 47.16% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc665f...c331251. Read the comment docs.

@shilman shilman added the maintenance User-facing maintenance tasks label Jul 8, 2017
@ndelangen ndelangen merged commit f2054b9 into release/3.2 Jul 8, 2017
@ndelangen ndelangen deleted the 1433-fix-alpha-versions branch July 8, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants