Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass full docs options to manager #18762

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

tmeasday
Copy link
Member

Also read docsMode in useStorybookState() in Tree rather than with a ManagerConsumer

Issue: https://linear.app/chromaui/issue/SB-505/info-remains-selected-when-changing-story

What I did

  • Inject docsMode into docsOptions
  • Pass docsOptions to the manager
  • Get docsOptions in the Tree in a more "reactive" way to fix the issue

How to test

Run react-ts with and without --docs

Also read `docsMode` in `useStorybookState()` in `Tree` rather than with a `ManagerConsumer`
@tmeasday tmeasday requested a review from ndelangen July 22, 2022 00:12
@nx-cloud
Copy link

nx-cloud bot commented Jul 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b204d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Base automatically changed from future/base to next July 25, 2022 10:37
@ndelangen
Copy link
Member

We should likely add as e2e test for this later.

@tmeasday
Copy link
Member Author

This would have been picked up by an chromatic interaction test of the sidebar / related components I think.

@tmeasday tmeasday merged commit 9711bfc into next Jul 26, 2022
@tmeasday tmeasday deleted the tom/sb-505-info-remains-selected-when-changing branch July 26, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants