Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release process documentation #1882

Merged
merged 2 commits into from
Sep 23, 2017
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 22, 2017

Issue: N/A

What I did

Update release process documentation to match what I've been doing in 3.x releases
and so other people can also run releases and also give feedback

How to test

Run the release process by hand if you have permissions to publish

Is this testable with jest or storyshots?

Not currently

Does this need a new example in the kitchen sink apps?

Nope

Does this need an update to the documentation?

This is an update to the documentation 😉

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested a review from ndelangen September 22, 2017 18:42
@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #1882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1882   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      698      687   -11     
=======================================
  Hits         1224     1224           
- Misses       3970     4000   +30     
+ Partials      545      515   -30
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.43% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748e595...f8e419d. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi Hypnosphi merged commit 2c318e6 into master Sep 23, 2017
@ndelangen ndelangen deleted the document-release-process branch September 24, 2017 08:24
@Hypnosphi Hypnosphi mentioned this pull request Sep 24, 2017
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants