Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execa 6.x in scripts #19759

Merged
merged 12 commits into from
Nov 21, 2022
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Nov 5, 2022

We need to use an obtuse method to import it as it is ESM only and ts-node doesn't play well with that.

See TypeStrong/ts-node#1290

How to test

I'm not sure how to test all the other scripts, but if the CI passes, the task runner is working

We need to use an obtuse method to import it as it is ESM only and `ts-node` doesn't play well with that.

See TypeStrong/ts-node#1290
@tmeasday tmeasday requested a review from ndelangen November 5, 2022 10:13
@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Nov 5, 2022
@ndelangen
Copy link
Member

@tmeasday

All looks good to me, except for this failure:

Error [ERR_REQUIRE_ESM]: require() of ES Module /tmp/storybook/scripts/node_modules/execa/index.js from /tmp/storybook/scripts/combine-compodoc.ts not supported.
Instead change the require of index.js in /tmp/storybook/scripts/combine-compodoc.ts to a dynamic import() which is available in all CommonJS modules.
    at Object.require.extensions.<computed> [as .js] (/tmp/storybook/scripts/node_modules/ts-node/dist/index.js:851:20)
    at Object.<anonymous> (/tmp/storybook/scripts/combine-compodoc.ts:10:17)
    at Module.m._compile (/tmp/storybook/scripts/node_modules/ts-node/dist/index.js:857:29)
    at Object.require.extensions.<computed> [as .ts] (/tmp/storybook/scripts/node_modules/ts-node/dist/index.js:859:16)
    at phase4 (/tmp/storybook/scripts/node_modules/ts-node/dist/bin.js:466:20)
    at bootstrap (/tmp/storybook/scripts/node_modules/ts-node/dist/bin.js:54:12)
    at main (/tmp/storybook/scripts/node_modules/ts-node/dist/bin.js:33:12)
    at Object.<anonymous> (/tmp/storybook/scripts/node_modules/ts-node/dist/bin.js:579:5) {
  code: 'ERR_REQUIRE_ESM'

@tmeasday tmeasday merged commit bd01d58 into next Nov 21, 2022
@tmeasday tmeasday deleted the tom/sb-880-update-execa-and-try-to-fix-waiting branch November 21, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants