-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add e2e-tests-dev task #21546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we factor things so we share the code between the two files?
We could have them read the same lib.
We could also consider a more complicated system where we can run any of the final tasks against either dev
or build
(arguably we could also run the test-runner
task against dev
also?) and have a flag that chooses between them, or a e2e-tests-dev
task that depends on dev
and e2e-tests
somehow? Probably not the right time to think about that!
Also, let's make a ticket where we delete smoke testing from the repo if we all agree we don't need it any more. |
Would you like to take a stab at it @tmeasday? Feel free to change this PR or make a telescoping one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday @yannbf Can we limit our dev coverage to 1 webpack-based project and 1 vite-based project and perhaps 1-2 others at most? If not, we're nearly doubling our CI costs, right? If we adopt nx affected
and are able to dramatically reduce costs that way, we can look at testing dev more aggressively. WDYT?
e3b9acf
to
01e21c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should talk about a better way to disable a given task at a given cadence but this way is good for now!
01e21c9
to
337d72d
Compare
337d72d
to
d2b8916
Compare
@yannbf if you are stuck I can have a go at figuring it out tomorrow perhaps? |
Thank you! |
1500e63
to
231aee4
Compare
What I did
We have been running e2e tests against built Storybooks, but not against Storybooks in dev mode.
This PR solves that!
How to test
Run a e2e-tests-dev for template, e.g.
yarn task --task e2e-tests-dev --start-from auto --template react-vite/default-ts
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]