Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon Measure: Deactivate when switching to Docs mode #21602

Merged
merged 3 commits into from
May 9, 2023
Merged

Addon Measure: Deactivate when switching to Docs mode #21602

merged 3 commits into from
May 9, 2023

Conversation

gitstart
Copy link
Contributor

Issue: #21327

What I did

  • Disable measure tool in Docs mode

How to test

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @phunguyenmurcul
chore: activate measure tool only in story mode
a1deda0 
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review March 14, 2023 15:31
@yannbf yannbf self-assigned this Mar 20, 2023
@yannbf yannbf added the bug label Apr 24, 2023
yannbf
yannbf approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, thank you for your contribution @gitstart !

@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 9, 2023
@yannbf yannbf changed the title Addon-measure: Deactivate when switch to Docs mode Addon Measure: Deactivate when switching to Docs mode May 9, 2023
@yannbf yannbf merged commit f0febc6 into storybookjs:next May 9, 2023
@shilman shilman mentioned this pull request May 10, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 12, 2023
shilman pushed a commit that referenced this pull request May 12, 2023
@yannbf @shilman
Merge pull request #21602 from gitstart/addon-measure/disable-in-docs
83d1115 
Addon Measure: Deactivate when switching to Docs mode
@shilman shilman mentioned this pull request May 12, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@yannbf yannbf

Labels
addon: measure bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitstart @yannbf @shilman