Avoid logging an object on compilation errors [2] #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain configurations Storybook might log the whole Webpack build object when warnings or errors are thrown. This was caused by a `logger.error` call inside the `index.js` catch. This fixes by logging the error only when it's an instance of an error.
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 21.42% 21.42%
=======================================
Files 263 263
Lines 5807 5807
Branches 698 698
=======================================
Hits 1244 1244
Misses 4031 4031
Partials 532 532
Continue to review full report at Codecov.
|
danielduan
approved these changes
Nov 1, 2017
|
@Hypnosphi @danielduan In what case is the thrown object not an error? I don't understand this PR (not saying it's wrong, just want to know before I release it). Thanks! |
|
See #1889 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2121 but for both react and vue apps (the change doesn't seem to make sense for RN app)