-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Mark qwik as using addon-interactions #22000
Conversation
@literalpie let me know when you merge/release that PR and I'll merge/release this one? |
I think merging this one first would be best. The Qwik-framework PR reference the package added by this PR, so merging that one first will cause build failures for people until this one merged. I don't think the reverse is true. |
@shilman are you okay with merging this one first? I'd also be willing to release my package's update first too, it's just not my first choice. (either way shouldn't be a big deal as long as we're quick about it) |
@literalpie sorry I missed your previous comment. Fine with me. Can you update your PR from |
bb83936
to
5e8acd0
Compare
@literalpie Done! Do you need me to release? |
Sweet! Yes, if you can that would be good. I can start a release too |
@literalpie here you go. i'll release it on Confusingly, this is on the |
Great! Thank you |
CLI: Mark qwik as using addon-interactions
What I did
Add Qwik to the list of frameworks that supports interactive stories.
See this PR in the storybook-framework-qwik project where I update the templates to match other frameworks. If I release that before this PR, the storybook addon-interactions dependency will be missing for people who use npm init with Qwik.
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]