-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addon Knobs: add array in Object PropTypes #2227
Fix addon Knobs: add array in Object PropTypes #2227
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
=======================================
Coverage 22.16% 22.16%
=======================================
Files 268 268
Lines 5875 5875
Branches 710 701 -9
=======================================
Hits 1302 1302
- Misses 4027 4045 +18
+ Partials 546 528 -18
Continue to review full report at Codecov.
|
This is already fixed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Should we backport the changes in docs as well? |
Yes that sounds like the logical thing to do! |
@jebarjonet Do you want to add the documentation changes? |
@jebarjonet do you want to do that? It should be just a matter of copypasting |
@ndelangen @Hypnosphi I updated the doc :) (I did not update stories as they are not the same as in |
@jebarjonet Thank you for this, really appreciate you helping us out, every small improvement helps! 🙇 If you want to help more and are looking for something, feel free to message me 👍 |
Knobs addon
value
prop inobject
type of knob now acceptsPropTypes.array
, while onlyPropTypes.object
was accepted.We now avoid warnings when we use arrays of objects in
object
knobs, which actually works perfectly fine.Example working fine but throwing warnings in browser console concerning Proptypes.