Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIGRATION.md #2709

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Update MIGRATION.md #2709

merged 2 commits into from
Jan 11, 2018

Conversation

Hypnosphi
Copy link
Member

There are some breaking changes in 3.3 that arent reflected in migration guide

@@ -18,7 +18,20 @@

## From version 3.2.x to 3.3.x

There should be no breaking changes in this release, but read on if you're using `addon-knobs`: we advise an update to your code for efficiency's sake.
There wasn't expected be any breaking changes in this release, but unfortunately it turned out that there are some. We're revisiting our [release strategy](https://github.com/storybooks/storybook/blob/master/RELEASES.md) to follow semver more strictly.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: replace "we're revisiting" with "we've revisited" once we update the RELEASES.md file

@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #2709 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2709   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         390      390           
  Lines        8772     8772           
  Branches      898      896    -2     
=======================================
  Hits         3014     3014           
+ Misses       5166     5155   -11     
- Partials      592      603   +11
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 33.96% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
addons/info/src/components/Story.js 88.88% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0125e7...0f8a22c. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 26a6061 into master Jan 11, 2018
@shilman shilman deleted the Hypnosphi-patch-1 branch January 11, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants