-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MIGRATION.md #2709
Update MIGRATION.md #2709
Conversation
@@ -18,7 +18,20 @@ | |||
|
|||
## From version 3.2.x to 3.3.x | |||
|
|||
There should be no breaking changes in this release, but read on if you're using `addon-knobs`: we advise an update to your code for efficiency's sake. | |||
There wasn't expected be any breaking changes in this release, but unfortunately it turned out that there are some. We're revisiting our [release strategy](https://github.com/storybooks/storybook/blob/master/RELEASES.md) to follow semver more strictly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: replace "we're revisiting" with "we've revisited" once we update the RELEASES.md
file
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
=======================================
Coverage 34.35% 34.35%
=======================================
Files 390 390
Lines 8772 8772
Branches 898 896 -2
=======================================
Hits 3014 3014
+ Misses 5166 5155 -11
- Partials 592 603 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are some breaking changes in
3.3
that arent reflected in migration guide