Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Report Fragment with div #3372

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Replacing Report Fragment with div #3372

merged 2 commits into from
Apr 5, 2018

Conversation

timothymclane
Copy link
Contributor

Issue:

What I did

Replaced usage of React.Fragment with div as discussed in #3370.

@Hypnosphi Hypnosphi added bug addon: a11y patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2018
@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #3372 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3372   +/-   ##
=======================================
  Coverage   36.82%   36.82%           
=======================================
  Files         458      458           
  Lines       10033    10033           
  Branches      890      898    +8     
=======================================
  Hits         3695     3695           
+ Misses       5818     5808   -10     
- Partials      520      530   +10
Impacted Files Coverage Δ
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
addons/storysource/src/loader/parse-helpers.js 46.75% <0%> (ø) ⬆️
app/angular/src/server/ts_config.js 38.09% <0%> (ø) ⬆️
addons/jest/src/components/Result.js 0% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Files.js 14.28% <0%> (ø) ⬆️
addons/storysource/src/loader/traverse-helpers.js 60.86% <0%> (ø) ⬆️
addons/storysource/src/loader/generate-helpers.js 44.44% <0%> (ø) ⬆️
addons/viewport/src/preview/components/Viewport.js 89.36% <0%> (ø) ⬆️
addons/knobs/src/components/GroupTabs.js 30.48% <0%> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c84288...1488214. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 6608ddd into storybookjs:master Apr 5, 2018
@timothymclane timothymclane deleted the removing-fragment-usage-from-addon-a11y branch April 6, 2018 13:44
Hypnosphi added a commit that referenced this pull request Apr 10, 2018
…rom-addon-a11y

Replacing Report Fragment with div
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: a11y bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants