allow setting params to storyshot #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldpipowitch
requested review from
Hypnosphi,
igor-dv and
thomasbertet
as code owners
donaldpipowitch
force-pushed
the
allow-setting-params-to-storyshot
branch
2 times, most recently
from
11e6460 to
e8f8ce6
Compare
|
Can you take a look on the failing tests ? |
donaldpipowitch
force-pushed
the
allow-setting-params-to-storyshot
branch
from
e8f8ce6 to
b315898
Compare
|
Hi @igor-dv , sorry, I haven't noticed the failing tests. Looks like I covered |
igor-dv
approved these changes
Sep 17, 2018
| const storyUrl = `/iframe.html?selectedKind=${encodedKind}&selectedStory=${encodedStoryName}`; | ||
| const { protocol, host, pathname, search } = new URL(storybookUrl); | ||
| const pname = pathname.replace(/\/$/, ''); // removes trailing / | ||
| const query = search.replace('?', '&'); // convert leading $ to & |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4119
What I did
Use
require('url').URLto parse thestorybookUrl. Available since Node v6. (Not sure, what you require here?) Construct the new URL.How to test
Is this testable with Jest or Chromatic screenshots? Yes
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? Yes
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]