add height and overflow fixes to addon panel styles #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmilner
requested review from
alexandrebodin,
alterx,
Hypnosphi,
jbovenschen,
leonrodenburg,
rhalff,
saponifi3d and
theinterned
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4304 +/- ##
==========================================
- Coverage 36.2% 36.19% -0.01%
==========================================
Files 556 556
Lines 6560 6561 +1
Branches 848 848
==========================================
Hits 2375 2375
- Misses 3754 3755 +1
Partials 431 431
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4303
What I did
Add height and overflow styles to Panel wrappers
How to test
addon-a11y
https://storybooks-official.netlify.com/?selectedKind=Addons%7Ca11y&selectedStory=Default&full=0&addons=1&stories=1&panelRight=0&addonPanel=%40storybook%2Faddon-a11y%2Fpanel
addon-actions
https://storybooks-official.netlify.com/?selectedKind=Addons%7CActions&selectedStory=Hello%20World&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
addon-knobs
https://storybooks-official.netlify.com/?selectedKind=Addons%7CKnobs.withKnobs&selectedStory=tweaks%20static%20values&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs
addon-viewport
https://storybooks-official.netlify.com/?selectedKind=Addons%7CViewport.Custom%20Default%20%28Kindle%20Fire%202%29&selectedStory=Inherited&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook-addon-viewport%2Faddon-panel