ADD timeout to update check #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4530 +/- ##
==========================================
- Coverage 35.7% 35.69% -0.01%
==========================================
Files 557 557
Lines 6708 6709 +1
Branches 879 879
==========================================
Hits 2395 2395
- Misses 3858 3859 +1
Partials 455 455
Continue to review full report at Codecov.
|
igor-dv
reviewed
Oct 23, 2018
| fetch(`https://storybook.js.org/versions.json?current=${version}`), | ||
| // if fetch is too slow, we won't wait for it | ||
| new Promise((res, rej) => global.setTimeout(rej, 1500)), | ||
| ]); |
There was a problem hiding this comment.
Won't the const data = await fromFetch.json(); fail in case of a timeout?
There was a problem hiding this comment.
igor-dv
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if for some reason the update check 'hangs', we ignore it and continue without it.