Fix getblocksubsidy suggestions #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
template construction. fixes zcash#6960 Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
|
Commit-by-commit review recommended. I would be fine with omitting the last commit if we think it's too risky at this stage. |
|
@str4d and I decided this should be retargeted to after v6.0.0. |
Fix `getblocksubsidy`
Ensure that the "future timestamp" rule is correctly applied by block template construction
…ENTS. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…der. Previously it was deterministic, but depended on details of the `operator<` implementations of `FundingStreamRecipient`, `SaplingPaymentAddress`, and `CScript`. Now it is just the same order as in `vFundingStreams`. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
fix-getblocksubsidy-suggestions
branch
from
1540631
to
96bf945
Compare
|
Closing in favour of zcash#6965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSUFFICIENT_ADDRESSEStoINSUFFICIENT_RECIPIENTS.sapling::Builder: add funding stream outputs in a more predictable order.GetActiveFundingStreamElements.Note that
GetActiveFundingStreamElementsis used by consensus, so this requires consensus-level review.