Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwigStan tweaks #99

Merged
merged 4 commits into from
Oct 21, 2024
Merged

TwigStan tweaks #99

merged 4 commits into from
Oct 21, 2024

Conversation

ruudk
Copy link

@ruudk ruudk commented Oct 21, 2024

Review commit by commit.

By doing this, we only have to use {% types %} once, for the _form.html.twig.

ruudk added 3 commits October 21, 2024 11:59
This prevents the `false` type normally on `file_get_contents`.
This way, TwigStan knows the context automatically, and we don't
have to manually type it.
@ruudk ruudk changed the title Twigs tan tweaks TwigStan tweaks Oct 21, 2024
@ruudk
Copy link
Author

ruudk commented Oct 21, 2024

/cc @COil Ready for review.

@COil COil self-requested a review October 21, 2024 13:29
@COil COil added chore chore or cleanup improvement improvement of an existing feature dependencies Pull requests that update a dependency file feature branch Feeature branch demo labels Oct 21, 2024
Copy link
Member

@COil COil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruudk :)

@COil COil merged commit 56d58df into strangebuzz:twigstan Oct 21, 2024
@ruudk ruudk deleted the twigs-tan-tweaks branch October 21, 2024 19:22
COil pushed a commit that referenced this pull request Oct 21, 2024
COil pushed a commit that referenced this pull request Oct 21, 2024
COil pushed a commit that referenced this pull request Oct 21, 2024
COil pushed a commit that referenced this pull request Oct 21, 2024
COil pushed a commit that referenced this pull request Oct 21, 2024
COil pushed a commit that referenced this pull request Nov 17, 2024
COil pushed a commit that referenced this pull request Nov 17, 2024
COil pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore chore or cleanup dependencies Pull requests that update a dependency file feature branch Feeature branch demo improvement improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants