Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signer start #12

Closed
jackzampolin opened this issue Aug 7, 2021 · 0 comments · Fixed by #27
Closed

Refactor signer start #12

jackzampolin opened this issue Aug 7, 2021 · 0 comments · Fixed by #27
Assignees
@jtieri
Milestone
v2.0.0

Comments

@jackzampolin
Copy link
Member

The signer start command is currently entangled and way too large. It includes two separate pieces of functionality, the single signer and the cosigner: https://github.com/strangelove-ventures/horcrux/blob/main/cmd/horcrux/cmd/cosigner.go#L33

This function should be split up into a number of smaller functions and most of the logic should be moved into the signer/ directory.
@jackzampolin jackzampolin mentioned this issue Aug 7, 2021
Closed
11 tasks
@jtieri jtieri self-assigned this Sep 10, 2021
@jtieri jtieri mentioned this issue Sep 10, 2021
Merged
@jtieri jtieri linked a pull request Sep 10, 2021 that will close this issue
Refactor Cosigner/Signer Start #27
Merged
@jtieri jtieri added this to the v1.0.0 milestone Sep 10, 2021
agouin pushed a commit that referenced this issue Sep 6, 2022
@nitronit
Merge pull request #12 from nitronit/entangle-threshold-signer
3b0bd1c 
factorizing out localsigner config and update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtieri jtieri

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Refactor Cosigner/Signer Start strangelove-ventures/horcrux
2 participants
@jackzampolin @jtieri