Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up usage and flags #149

Merged
merged 5 commits into from
May 15, 2023
Merged

tidy up usage and flags #149

merged 5 commits into from
May 15, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented May 15, 2023

horcrux address

  • give a more helpful error including the chain ID if horcrux address <chain-id> fails to find they key

horcrux config init

  • [chain-nodes] is not an optional argument, it is required with --node flag(s)
  • clarify --node and --cosigner flags.

horcrux create-rsa-shards

  • shards is not an argument, but a required flag

horcrux create-ed25519-shards

  • all flags are required

horcrux state set

  • chain-id and height are required args

horcrux state import

  • chain-id is a required arg

cmd/horcrux/cmd/config.go Outdated Show resolved Hide resolved
cmd/horcrux/cmd/config.go Show resolved Hide resolved
cmd/horcrux/cmd/config.go Show resolved Hide resolved
@agouin agouin requested a review from DavidNix May 15, 2023 22:08
@agouin agouin merged commit cf9a0ce into main May 15, 2023
@agouin agouin deleted the andrew/cmd_tidy branch May 15, 2023 23:40
agouin added a commit that referenced this pull request May 16, 2023
* tidy up usage and flags

* Fix sign mode flag description

* nits

* add --bare flag to config init to disable validation

* update test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants