Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threshold signer integration into local cosigner #170

Merged
merged 2 commits into from
Jul 13, 2023
Merged

threshold signer integration into local cosigner #170

merged 2 commits into from
Jul 13, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Jul 12, 2023

Completes threshold signer integration into local cosigner.

Resolves #46

@agouin agouin marked this pull request as ready for review July 12, 2023 22:25
mark-rushakoff
mark-rushakoff approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't necessarily follow every change here, but I didn't spot any noticeable mistakes.

signer/threshold_validator.go Outdated Show resolved Hide resolved
signer/local_cosigner.go Outdated Show resolved Hide resolved
@agouin agouin merged commit 68d4265 into main Jul 13, 2023
3 checks passed
@agouin agouin deleted the andrew/threshold_signer_interface branch July 13, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-rushakoff mark-rushakoff mark-rushakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract local cosigner sign methods into interface
2 participants
@agouin @mark-rushakoff