Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosigner Security #171

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Cosigner Security #171

merged 4 commits into from
Jul 14, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Jul 13, 2023

First phase of #162

Refactors cosigner to cosigner encryption+signature into CosignerSecurity interface, paving the way for additional encryption+signature mechanisms.

@agouin agouin marked this pull request as ready for review July 13, 2023 19:01
Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious issues I could spot here.

signer/cosigner_security.go Outdated Show resolved Hide resolved
signer/cosigner_security.go Outdated Show resolved Hide resolved
signer/cosigner_security_rsa.go Outdated Show resolved Hide resolved
signer/cosigner_security_rsa.go Outdated Show resolved Hide resolved
signer/cosigner_security_rsa_test.go Outdated Show resolved Hide resolved
@agouin agouin merged commit 8eb5e28 into main Jul 14, 2023
3 checks passed
@agouin agouin deleted the andrew/cosigner_security branch July 14, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants