Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Horcrux go.mod module path #240

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

jakubbujny
Copy link
Contributor

Horcrux is currently at major version 3.X
From golang perspective module path should be updated to contain v3 in path, ref: https://go.dev/doc/modules/version-numbers#major

A major version update to a number higher than v1 will also have a new module path. That’s because the module path will have the major version number appended, as in the following example:
module example.com/mymodule/v2 v2.0.0

Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agouin agouin merged commit eef600c into strangelove-ventures:main Dec 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants