Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cosmos message poller #325

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Conversation

DavidNix
Copy link
Contributor

@DavidNix DavidNix commented Oct 14, 2022

Adds a new poll function for cosmos chains. The ability to poll for any arbitrary cosmos message.

I will use this in the relayer codebase to help with a test regarding keeping light clients up to date.

@DavidNix DavidNix requested a review from a team as a code owner October 14, 2022 15:16
@DavidNix DavidNix requested a review from agouin October 14, 2022 15:16
Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay generics!

@DavidNix DavidNix marked this pull request as draft October 14, 2022 15:59
@DavidNix
Copy link
Contributor Author

@agouin Thanks for the quick review! But apologies, this was still in draft. I'm trying to add another poller function which will leverage this generic refactor. That's great all tests pass though.

@DavidNix DavidNix force-pushed the nix/feat/cosmos-poll-for-message branch from f6d3fd9 to 80f03ae Compare October 14, 2022 18:15
@DavidNix DavidNix marked this pull request as ready for review October 17, 2022 19:28
@DavidNix DavidNix requested review from agouin and jtieri October 17, 2022 19:29
@@ -0,0 +1,6 @@
package cosmos_test

const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@DavidNix DavidNix merged commit 352b028 into main Oct 17, 2022
@DavidNix DavidNix deleted the nix/feat/cosmos-poll-for-message branch October 17, 2022 21:22
@DavidNix
Copy link
Contributor Author

Addresses cosmos/relayer#853

jtieri pushed a commit that referenced this pull request Jan 6, 2023
jtieri pushed a commit that referenced this pull request Jan 6, 2023
jtieri added a commit that referenced this pull request Jan 9, 2023
* fix: Unable to build ibctest binary (#326)

* feat: Add cosmos message poller (#325)

* fix: change import paths from v6 to v3

* Make configutil public (#336)

* Make configutil public

* Rename test package to chainutil. Make util packages subpackages of util package

* Consolidate into single testutil package

* fix: formatting issue in doc

* fix: change import path from test to testutil

* fix: go mod tidy

* packet-forward-middleware packet memo, retry on timeout, and atomic forwards (#306)

* Make examples its own module

* Make cosmos specific module and run in CI in separate task

* Update e2e test for memo refactor

* Update test to chain-level params

* Use gaia with pfm with configurable timeout and retries

* Update SendIBCTransfer uses

* fix interchain test

* Add GetClients method to Relayer and helper for getting transfer channel between chains

* Update packet forward test for multi-hop, add multi-hop refund test

* Update tests for atomic forwards

* Wait for a block after ack before checking balances

* reduce wait to 1 block

* Add multi-hop flow with refund through chain with native denom. Add assertions for escrow accounts

* Remove stale comment

* handle feedback

* Add TransferOptions

* fix: remove extra argument to NewMsgTransfer call

* build: go mod tidy

* chore: update gaia image version for packet forward tests

* fix: fallback to old version of the interchain accounts demo binary

Co-authored-by: David Nix <DavidNix@users.noreply.github.com>
Co-authored-by: Andrew Gouin <andrew@gouin.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants