[test] Add functional tests to test v2 P2P behaviour

test/functional/p2p_v2_encrypted.py

@@ -0,0 +1,103 @@
+#!/usr/bin/env python3
+# Copyright (c) 2022 The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+"""
+Test encrypted v2 p2p proposed in BIP 324
+"""
+from test_framework.blocktools import (
+    create_block,
+    create_coinbase,
+)
+from test_framework.p2p import (
+    P2PDataStore,
+    P2PInterface,
+)
+from test_framework.test_framework import BitcoinTestFramework
+from test_framework.util import (
+    assert_equal,
+    assert_greater_than,
+    check_node_connections,
+)
+
+class P2PEncrypted(BitcoinTestFramework):
+    def set_test_params(self):
+        self.num_nodes = 2
+        self.extra_args = [["-v2transport=1"], ["-v2transport=1"]]
+
+    def setup_network(self):
+        self.setup_nodes()
+        # Don't connect the nodes
+
+    def run_test(self):
+        node0, node1 = self.nodes[0], self.nodes[1]
+
+        self.log.info("Check inbound connections to v2 TestNode from v2 P2PConnection is v2")
+        peer1 = node0.add_p2p_connection(P2PInterface(), wait_for_verack=True, support_v2_p2p=True, advertise_v2_p2p=True)
+        assert peer1.support_v2_p2p
+
+        self.log.info("Check inbound connection to v2 TestNode from v1 P2PConnection is v1")
+        peer2 = node0.add_p2p_connection(P2PInterface(), wait_for_verack=True, support_v2_p2p=False, advertise_v2_p2p=False)
+        assert not peer2.support_v2_p2p
+
+        self.log.info("Check outbound connection from v2 TestNode to v1 P2PConnection advertised as v1 is v1")
+        peer3 = node0.add_outbound_p2p_connection(P2PInterface(), p2p_idx=0, support_v2_p2p=False, advertise_v2_p2p=False)
+        assert not peer3.support_v2_p2p
+
+        # v2 TestNode performs downgrading here
+        self.log.info("Check outbound connection from v2 TestNode to v1 P2PConnection advertised as v2 is v1")
+        peer4 = node0.add_outbound_p2p_connection(P2PInterface(), p2p_idx=1, support_v2_p2p=False, advertise_v2_p2p=True)
+        assert not peer4.support_v2_p2p
+
+        self.log.info("Check outbound connection from v2 TestNode to v2 P2PConnection advertised as v1 is v1")
+        peer5 = node0.add_outbound_p2p_connection(P2PInterface(), p2p_idx=2, support_v2_p2p=True, advertise_v2_p2p=False)
+        assert not peer5.support_v2_p2p
+
+        self.log.info("Check if version is sent and verack is received in inbound/outbound connections")
+        assert_equal(len(node0.getpeerinfo()), 5) # check if above 5 connections are present in node0's getpeerinfo()
+        for peer in node0.getpeerinfo():
+            assert_greater_than(peer['bytessent_per_msg']['version'], 0)
+            assert_greater_than(peer['bytesrecv_per_msg']['verack'], 0)
+
+        self.log.info("Testing whether blocks propagate")
+        for i in range(2):
+            # Add v2 P2P connection to node0
+            peer6 = node0.add_p2p_connection(P2PDataStore(), support_v2_p2p=True, advertise_v2_p2p=True)
+            assert peer6.support_v2_p2p
+            best_block = node0.getbestblockhash()
+            tip = int(best_block, 16)
+            best_block_time = node0.getblock(best_block)['time']
+            # Create some blocks
+            block = create_block(tip, create_coinbase(node0.getblockcount() + 1), best_block_time + 1)
+            block.solve()
+            if i:
+                # check if node1 connected to node0 (but not to node0's p2p connection directly)
+                # gets block produced by node0's p2p connection
+                self.log.info("Check if blocks produced by node0's p2p connection is received by node0")
+                peer6.send_blocks_and_test([block], node0, success=True) # node0's tip advances
+            else:
+                # check if node1 connected to node0 (but not to node0's p2p connection directly) and node0 - both
+                # do not get block produced by node0's p2p connection if the messages sent are decoys
+                self.log.info("Check if blocks produced by node0's p2p connection sent as decoys aren't received by node0")
+                peer6.send_blocks_and_test([block], node0, success=False, is_decoy=True) # node0's tip doesn't advance
+            # Connect node0 and node1 using v2
+            self.connect_nodes(0, 1, use_p2p_v2=True)
+            self.log.info("Wait for node1 to receive all the blocks from node0")
+            self.sync_all()
+            self.log.info("Make sure node0 and node1 have same block tips")
+            assert_equal(node0.getbestblockhash(), node1.getbestblockhash())
+
+            self.disconnect_nodes(0, 1)
+
+        self.log.info("Check the connections opened as expected")
+        check_node_connections(node=node0, num_in=4, num_out=3)
+
+        self.log.info("Check inbound connections to v1 TestNode from v2 P2PConnection is v1")
+        self.restart_node(0, ["-v2transport=0"])
+        # advertise_v2_p2p is used to falsely advertise v1 TestNode as a v2 TestNode
+        peer7 = node0.add_p2p_connection(P2PInterface(), wait_for_verack=True, support_v2_p2p=True, advertise_v2_p2p=True)
+        assert not peer7.support_v2_p2p
+        check_node_connections(node=node0, num_in=1, num_out=0)
+
+if __name__ == '__main__':
+    P2PEncrypted().main()

test/functional/test_runner.py

@@ -212,6 +212,7 @@
     'p2p_invalid_block.py',
     'p2p_invalid_messages.py',
     'p2p_invalid_tx.py',
+    'p2p_v2_encrypted.py',
     'p2p_v2_transport.py',
     'feature_assumevalid.py',
     'example_test.py',