fix daattali#82 - setSelection didn't trigger the shiny selected input

strazto · Oct 1, 2020 · 221b84e · 221b84e
1 parent 80e3771
commit 221b84e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: timevis
 Title: Create Interactive Timeline Visualizations in R
-Version: 0.5.0.9003
+Version: 0.5.0.9004
 Authors@R: c(
     person("Dean", "Attali", email = "daattali@gmail.com",
       role = c("aut", "cre"), comment = "R interface"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,9 +1,10 @@
 # timevis 0.5.*
 
-TODO
+TODO date
 
 - Add `timezone` parameter to `timevis()` - supports showing the timeline in a different timezone than your local machine (#67)
 - Add `setCustomTime()` and `setCurrentTime()` functions (#20)
+- Fixed bug: using `setSelection()` did not trigger the Shiny selected input (#82)
 - Add documentation about how to add custom style to timevis (#45)
 - Add documentation tab to the demo app
 

diff --git a/inst/htmlwidgets/timevis.js b/inst/htmlwidgets/timevis.js
@@ -233,6 +233,12 @@ HTMLWidgets.widget({
       },
       setSelection : function(params) {
         timeline.setSelection(params.itemId, params.options);
+        if (HTMLWidgets.shinyMode) {
+          Shiny.onInputChange(
+            elementId + "_selected",
+            params.itemId
+          );
+        }
       },
       setWindow : function(params) {
         timeline.setWindow(params.start, params.end, params.options);