Skip to content

Commit

Permalink
make api functions work in shiny modules; fixes daattali#90
Browse files Browse the repository at this point in the history
  • Loading branch information
daattali authored and strazto committed Oct 1, 2020
1 parent 598946c commit fec607c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: timevis
Title: Create Interactive Timeline Visualizations in R
Version: 0.5.0.9004
Version: 0.5.0.9005
Authors@R: c(
person("Dean", "Attali", email = "daattali@gmail.com",
role = c("aut", "cre"), comment = "R interface"),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

TODO date

- **BREAKING CHANGE** API functions now work in shiny modules without having to specify the namespace. This means that if you previously explicitly used a namespace when calling API functions, you need to remove the namespace (#90)
- Add `timezone` parameter to `timevis()` - supports showing the timeline in a different timezone than your local machine (#67)
- Add `setCustomTime()` and `setCurrentTime()` functions (#20)
- Fixed bug: using `setSelection()` did not trigger the Shiny selected input (#82)
Expand Down
1 change: 1 addition & 0 deletions R/api.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ callJS <- function() {
# If an ID was passed, the widget already exists and we can simply call the
# appropriate JS function
else if (is.character(message$id)) {
message$id <- session$ns(message$id)
method <- paste0("timevis:", message$method)
session$sendCustomMessage(method, message)
return(message$id)
Expand Down

0 comments on commit fec607c

Please sign in to comment.