-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0 #87
Release 3.0 #87
Conversation
Hey @dougwilson, I was looking at the remaining items to release |
Hi @wesleytodd yea, for sure. I will do that for ya tonight if at all possible to unblock you. I believe this was just prelease to coordinate with body-parser, but will double check and let you know 👍 |
Awesome! Yeah if there are notable changes we should call out in the changelog that would be good, but mainly I just think we are ready to start cutting the main line releases for some of these so we can get express v5 depending on them in a final beta release before we do the final push. Thanks for the help and hope life is going well! |
Oh, and in case it helps you, we plan on dropping all the way up to node 18, so are also going to greatly simplify the test setups for many of these deps. So if you were thinking about dropping more aggressively going forward that would be alright as far as Express is concerned. |
Hey, sorry to be a pest, but was just checking in since I see there were some dep updates if there was anything I could do to help here. Seems to pass CI, but let me know if there was any remaining work I could help with to get it published. |
Ya it is working now but not when I first sat down that night. It unfortunately took me a while to figure it out and went way over time that night and been making up for that these past couple days. I saw that iconv-lite is out of date so didn't release that night to see what is different so I could incorporate any breaking changes from that into this same one and start off 3.0 not already way behind is all. I am at work so cannot do anything right now but will try my best tonight. |
Cool thanks for the update. Not intending to put pressure on you, sorry, just making sure I am following up on things and make sure if there is anything I can do to help that I do that. Sounds like there is nothing here for me to help with though. |
No worries, sorry didn't mean to make you think that. Just was trying to relay the status. I am merging and releasing now, however 🎉 |
This is a tracking issue for release 3.0.
Please keep feature requests in their own issues
If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.
List of changes for release:
NodeJS.ReadableStream
interface Update types stream.Readable with NodeJS.ReadableStream #69iconv-lite
to 0.5.2 chore: bump iconv-lite to 0.5 #67iconv-lite
to 0.6.3Testing this release
If you want to try out this release, you can install it with the following commands:
Please do not merge until there is some kind of consensus / non-objection