fix: prevent callback from triggering twice when callback throws #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
commented
May 15, 2021
| }); | ||
|
|
||
| expect(() => jest.runAllTimers()).toThrow('try to trigger catch'); | ||
| }); |
There was a problem hiding this comment.
Since wrapAsync uses setImmediate to invoke the callback that throws an error, the error can't be caught.
The only way to catch it seemed to be by stubbing setImmediate, which the jest.useFakerTimers() at the top does. This queues all callbacks until jest.runAllTimers() is invoked, which runs the queued callbacks synchronously to catch the error being thrown.
jest.useFakerTimers() seemed to stub setImmediate for all tests in the file, so I had to put it in a separate file to only influence this specific test.
|
@streamich Could you please review this? |
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #542