fix: 🐛 cancel animation frame on un-mount in useWindowScroll()

streamich · Mar 23, 2019 · bc021ce · bc021ce
1 parent 94bffc5
commit bc021ce
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/useWindowScroll.ts b/src/useWindowScroll.ts
@@ -16,7 +16,6 @@ const useWindowScroll = (): State => {
   useEffect(() => {
     const handler = () => {
       cancelAnimationFrame(frame.current)
-
       frame.current = requestAnimationFrame(() => {
         setState({
           x: window.scrollX,
@@ -30,7 +29,10 @@ const useWindowScroll = (): State => {
       passive: true
     })
 
-    return () => window.removeEventListener('scroll', handler)
+    return () => {
+      cancelAnimationFrame(frame.current);
+      window.removeEventListener('scroll', handler);
+    };
   }, [])
 
   return state