fix: improve use of refs in dependency lists (#655)

streamich · Oct 12, 2019 · ed8e26d · ed8e26d
1 parent d4aec7a
commit ed8e26d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/useFullscreen.ts b/src/useFullscreen.ts
@@ -65,7 +65,7 @@ const useFullscreen = (ref: RefObject<Element>, on: boolean, options: FullScreen
         video.current.webkitExitFullscreen();
       }
     };
-  }, [ref.current, video, on]);
+  }, [on, video, ref]);
 
   return isFullscreen;
 };

diff --git a/src/useMouse.ts b/src/useMouse.ts
@@ -62,7 +62,7 @@ const useMouse = (ref: RefObject<Element>): State => {
       cancelAnimationFrame(frame.current);
       document.removeEventListener('mousemove', moveHandler);
     };
-  }, [ref.current]);
+  }, [ref]);
 
   return state;
 };

diff --git a/src/useScroll.ts b/src/useScroll.ts
@@ -48,7 +48,7 @@ const useScroll = (ref: RefObject<HTMLElement>): State => {
         ref.current.removeEventListener('scroll', handler);
       }
     };
-  }, [ref.current]);
+  }, [ref]);
 
   return state;
 };

diff --git a/src/useScrolling.ts b/src/useScrolling.ts
@@ -25,7 +25,7 @@ const useScrolling = (ref: RefObject<HTMLElement>): boolean => {
       };
     }
     return () => {};
-  }, [ref.current]);
+  }, [ref]);
 
   return scrolling;
 };