Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useHoverDirty deps #638

Closed
wants to merge 1 commit into from
Closed

Fix useHoverDirty deps #638

wants to merge 1 commit into from

Conversation

rskull
Copy link

@rskull rskull commented Oct 2, 2019

useHoverDirty is not working.

@wardoost
Copy link
Contributor

wardoost commented Oct 7, 2019

I did some testing and the current version actually implements it correctly. Also see this quote from facebook/react#16121 (comment):

However, it doesn’t make sense to add ref.current as a dependency. For the same reason it doesn’t make sense to add window.myVariable. When it updates, React won’t know about it, and won’t update your component.

@wardoost wardoost closed this Oct 7, 2019
@wardoost wardoost self-requested a review October 7, 2019 10:29
@wardoost wardoost mentioned this pull request Oct 7, 2019
Merged
@wardoost wardoost removed their request for review October 7, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rskull @wardoost