Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timestamp type #6

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add Timestamp type #6

merged 2 commits into from
Sep 10, 2024

Conversation

YaroShkvorets
Copy link
Contributor

Since a few month ago graph-node has Timestamp type.
This PR adds support for it with int64 underlying type

Once this is approved I'll submit this PR to graph-node: graphprotocol/graph-node#5641

maoueh
maoueh approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@maoueh maoueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing is how graph-node will react when receiving this new event type without being aware of it.

As of this repo, this is fine. Let's coordinate for a release with graph-node.

@maoueh maoueh merged commit 67ef49f into streamingfast:develop Sep 10, 2024
1 check passed
@YaroShkvorets YaroShkvorets deleted the yaro/add_timestamp branch September 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoueh maoueh maoueh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaroShkvorets @maoueh @Dirt-Nasty