Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FlattenedStreamId to accept subclasses of Iterable #10

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

LaMonF
Copy link
Contributor

@LaMonF LaMonF commented Sep 29, 2017

Currently FlattenedStreamId accepts a source stream id as "StreamId<Iterable<? extends T>>". That creates a problem if we want to pass "StreamId<List<? extends T>>". Therefore we changed Iterable to "? extends Iterable".

Currently FlattenedStreamId accepts a source stream id as "StreamId<Iterable<? extends T>>". That creates a problem if we want to pass "StreamId<List<? extends T>>". Therefore we changed Iterable to "? extends Iterable".
@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     49.36%   49.36%           
  Complexity      248      248           
=========================================
  Files            72       72           
  Lines          1108     1108           
  Branches        158      158           
=========================================
  Hits            547      547           
  Misses          500      500           
  Partials         61       61
Impacted Files Coverage Δ Complexity Δ
.../service/streamfactory/FlattenedStreamFactory.java 100% <100%> (ø) 5 <1> (ø) ⬇️
...gpool/core/service/streamid/FlattenedStreamId.java 21.73% <100%> (ø) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74385d...368c295. Read the comment docs.

@andreacalia andreacalia merged commit 5c4dbad into streamingpool:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants