This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[transactions] Reduce spammy log during broker shutdown #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1896 +/- ##
============================================
- Coverage 18.77% 18.77% -0.01%
Complexity 743 743
============================================
Files 184 184
Lines 13289 13292 +3
Branches 1211 1213 +2
============================================
Hits 2495 2495
- Misses 10613 10616 +3
Partials 181 181
|
Comment on lines
333
to
339
| if (throwable instanceof PulsarClientException.LookupException | ||
| || throwable.getCause() instanceof PulsarClientException.LookupException) { | ||
| log.warn("Failed to find broker for topic partition {} - {}", topicPartition, | ||
| throwable + ""); | ||
| } else { | ||
| log.warn("Failed to find broker for topic partition {}", topicPartition, throwable); | ||
| } |
There was a problem hiding this comment.
How could it reduce the spammy logs? For the lookup exception, there are still warn logs.
There was a problem hiding this comment.
Yes, but when the cause is LookupException, it won't print the stack info.
There was a problem hiding this comment.
it won't print the stack info.
I think not. See line 335, it's still log.warn.
gaoran10
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce spammy log during broker shutdown
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)